Skip to content
This repository was archived by the owner on Dec 16, 2020. It is now read-only.

gRPC wasm stress test (happy path)#90

Merged
duderino merged 3 commits intoenvoyproxy:masterfrom
duderino:jblatt_wasm_stress_tests
Jul 26, 2019
Merged

gRPC wasm stress test (happy path)#90
duderino merged 3 commits intoenvoyproxy:masterfrom
duderino:jblatt_wasm_stress_tests

Conversation

@duderino
Copy link
Contributor

Needs to be rebased once #89 is merged.

Together with #89, this fully replaces #72

@duderino duderino requested review from jplevyak and lambdai July 23, 2019 17:05
@duderino duderino requested a review from PiotrSikora as a code owner July 23, 2019 17:05
@duderino duderino force-pushed the jblatt_wasm_stress_tests branch 2 times, most recently from e503a12 to e71b989 Compare July 23, 2019 20:43
@jplevyak
Copy link
Contributor

Looks good subject to the merge and update WRT #86

Copy link
Contributor

@jplevyak jplevyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the exception handling in the wasm code.

@duderino duderino force-pushed the jblatt_wasm_stress_tests branch from e71b989 to 1520731 Compare July 25, 2019 05:54
Signed-off-by: Joshua Blatt <jtblatt@gmail.com>
@duderino duderino force-pushed the jblatt_wasm_stress_tests branch from 1520731 to 3887661 Compare July 25, 2019 05:57
@duderino duderino changed the title Jblatt wasm stress tests gRPC wasm stress test (happy path) Jul 25, 2019
@duderino
Copy link
Contributor Author

duderino commented Jul 25, 2019

asan error looks transient

ERROR: /build/tmp/_bazel_bazel/b570b5ccd0454dc9af9f65ab1833764d/external/envoy/bazel/BUILD:218:1: @envoy//bazel:wee8 depends on @wee8_linux//:wee8 in repository @wee8_linux which failed to fetch. no such package '@wee8_linux//': java.io.IOException: Error downloading [https://storage.googleapis.com/envoyproxy-wee8/wee8-7.5.288.22-linux-x86_64.tar.gz] to /build/tmp/_bazel_bazel/b570b5ccd0454dc9af9f65ab1833764d/external/wee8_linux/wee8-7.5.288.22-linux-x86_64.tar.gz: connect timed out

I can fetch that directly with wget

@duderino
Copy link
Contributor Author

Please remove the exception handling in the wasm code.

done

@duderino duderino requested a review from jplevyak July 25, 2019 06:05
duderino added 2 commits July 24, 2019 23:06
Signed-off-by: Joshua Blatt <jtblatt@gmail.com>
Signed-off-by: Joshua Blatt <jtblatt@gmail.com>
@duderino duderino merged commit 2a21d58 into envoyproxy:master Jul 26, 2019
mandarjog pushed a commit to mandarjog/envoy-wasm that referenced this pull request Aug 21, 2019
Merge from envoyproxy/envoy-wasm:master
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants